search

connext / indra

[LEGACY] Monorepo containing everything related to the core Connext protocols and network.
MIT License
84 stars 38 forks source link

Block pushing versioned images if those images already exist #199

Closed bohendo closed 5 years ago

bohendo commented 5 years ago

Current Behavior

If we forget to increment the version in package.json & deploy, we clobber our old images and make it harder to roll-back if something goes wrong.

Possible Solution

Before pushing versioned images, check whether this version already exists on docker hub. If so, abort.

Something similar is already done in indra/ops/pre-push.sh, just gotta repackage that & activate it pre-image-push too.

LayneHaber commented 5 years ago

closing, should be handled by existing deploy scripts 🎉