Fall back to our own estimate fee calculation and share between sequencer and SDK

rhlsthrm commented 1 year ago

Problem

What problem are we solving and why does it matter, ser? SDK and sequencer calculate the relayer fee separately. Also in some cases our external API returns 0.

Proposed Solution

Thoughts on solution design. We should do to solve this problem.

[ ] If the fee returned is 0 (or errors), fall back to using providers to get gas price.
[ ] Ensure the logic is the exact same between SDK and sequencer.

Acceptance Criteria

From an end tester and/or user perspective, the below criteria must be met to consider this done:

[ ] Above issues are resolved.

wanglonghong commented 1 year ago

We were depending on our own price oracle contract to implement fallback mechanism but it looks like we don't use it on amarok

rhlsthrm commented 1 year ago

Since we only use gas tokens, we can use off the shelf APIs such as CoinGecko for this. Maybe we should have a few that we cycle between.

connext / monorepo