connext / monorepo

Connext is a modular stack for trust-minimized, generalized communication between blockchains.
https://docs.connext.network
MIT License
292 stars 172 forks source link

New SDK + API #3732

Closed ArjunBhuptani closed 1 month ago

ArjunBhuptani commented 1 year ago

SDK currently imports too many dependencies, resulting in a bloated bundle which can be untenable for integrators.

New SDK spec: https://www.notion.so/connext/Connext-New-SDK-Spec-fa52e9f465314102b47cf82f233013c3

alexwhte commented 1 year ago

now that we're relying a lot on SDK for integrations were starting to see some issues with it being bloated and pulling in a lot of deps which it doesnt need. i think its worth redesigning the SDK and deps from the ground up to make sure its super lightweight and works super well some dapps wont integrate us if the SDK is over a certain bundle size

https://discord.com/channels/992549151134982234/1083352842133319720

alexwhte commented 1 year ago

Work in #3749 is higher pri, this requires more scoping out

rhlsthrm commented 1 year ago

https://www.notion.so/connext/SDK-Optimization-3749cc1cd7824e568df5ca153fe351c8?pvs=4

Scoped here.

alexwhte commented 1 year ago

@just-a-node will add Chai stuff to the spec

rodsouto commented 1 year ago

Hi, I'm having this problem too. I just need to estimate the relayer fee, but installing the sdk increases the bundle size almost 2.5MB (a 3.4x increase compared to the previous size).

It would be great to have better tree shaking support to improve this.

rhlsthrm commented 1 year ago

Adding spec here:

Tasks:

alexwhte commented 1 year ago

Complexity: 13 See the discussion in Backlog Prio 1

Powered by Parabol

alexwhte commented 1 year ago

Impact: 4 See the discussion in Backlog Prio 1

Powered by Parabol

alexwhte commented 1 year ago

Urgency: 3 See the discussion in Backlog Prio 1

Powered by Parabol

alexwhte commented 1 year ago

Complexity: 13 See the discussion in Sprint Poker #​​26

Powered by Parabol

alexwhte commented 1 year ago

Impact: 4 See the discussion in Sprint Poker #​​27

Powered by Parabol

alexwhte commented 1 year ago

Urgency: 4 See the discussion in Sprint Poker #​​27

Powered by Parabol

alexwhte commented 1 year ago

Complexity: 21 See the discussion in Sprint Poker #​​29

Powered by Parabol

alexwhte commented 1 year ago

Impact: 4 See the discussion in Sprint Poker #​​30

Powered by Parabol

alexwhte commented 1 year ago

Urgency: 3 See the discussion in Sprint Poker #​​30

Powered by Parabol

alexwhte commented 9 months ago

note: Max from LiFi complained about server issues last week. Doing this will enable us to move out of server to stop hosting SDK

alexwhte commented 9 months ago

note off of recent Socket issues:
Aggregator integrations can technically read pool contracts to see if there's enough liquidity. SDK could have helper functions to make that easier. But relying on that can run into issues with too many calls

consdier other iterations on docs to handle this instaed and focus on performance

t0rbik commented 2 months ago

Hey all, is there an ETA for the update? Thanks.

just-a-node commented 1 month ago

We'll be releasing an Everclear API so this will be sunset