connext / monorepo

Connext is a modular stack for trust-minimized, generalized communication between blockchains.
https://docs.connext.network
MIT License
284 stars 163 forks source link

[ICE: 20] High relayer fees estimation - UI malfunction? #6135

Open MinistroDolar opened 2 months ago

MinistroDolar commented 2 months ago

Describe the bug A user sent 0.005 ETH from Linea to Ethereum Mainnet and paid 0.069938ETH as relayer fee:

https://connextscan.io/tx/0xc5152f6af5ac9b8d778b381310ffbd406c507241f457e3b653e83deebc7c7325

image

but when the txn arrives it costs 0.02413873 ETH https://etherscan.io/tx/0x3c2c562b11c8bd36eed9658969b86ab5aeae50e44a71774c24034e34cd96c176

image

Relayer fees were overestimated?.

Also, there is another issue, in cases like this (where Fees are greater than estimate received) a pop-up should like this should appear:

image

But seems that the user was able to bridge, so i guess that something didn't work as intended in our UI.

Ticket:

https://discord.com/channels/454734546869551114/1234846071642132480

@oncall

ekbainova commented 2 months ago

@just-a-node need to check it.

regexpressyourself commented 2 months ago

I'm seeing a relayer fee of .0699 ETH coming back from sdk.sdkUtils.getTransfers({ transactionHash: '0xc5152f6af5ac9b8d778b381310ffbd406c507241f457e3b653e83deebc7c7325' }), so I think the UI is displaying the data correctly.

Is the SDK call incorrect perhaps?

0xanedi commented 2 months ago

Any update? @regexpressyourself We should definitely block transactions where the relayer fee exceeds the sent amount in value, and also display the message like @MinistroDolar said.

regexpressyourself commented 2 months ago

@0xanedi Did a bit of digging with Eddie on Friday, not sure what exactly happened in this case.

It looks like the SDK is returning the correct value. It also looks like the UI blocks users from bridging when fees are greater than the value.

I have been unable to reproduce a situation where we allow the user to bridge when fees exceed the amount.

image

Are we seeing any more examples of users being able to bridge an amount less than the fees incurred?

0xanedi commented 2 months ago

We'll be on the lookout. Will inform Support Team. Fraid I haven't seen further cases yet.

ekbainova commented 2 months ago

Not 100% sure that it is the same: https://app.intercom.com/a/inbox/qge2vd8z/inbox/conversation/675?view=List https://connextscan.io/tx/0xa32be9ad5f1c6d0a80d3b944aa4c5fb2d352862c7626d4602b2744b720b1c4e3

ekbainova commented 2 months ago

connext_2024_05_05_675.txt

just-a-node commented 2 months ago

Based on our attempts at troubleshooting, I would advise keeping this open for the next ~3 days to monitor for additional cases. It's unclear if the case above is the same. If nothing rolls in, let's close.

MinistroDolar commented 1 month ago

Based on our attempts at troubleshooting, I would advise keeping this open for the next ~3 days to monitor for additional cases. It's unclear if the case above is the same. If nothing rolls in, let's close.

What resolution should we take regarding the user? Something went wrong in her case. She is quite upset and has been insisting on a response from the team for several days. https://discord.com/channels/454734546869551114/1234846071642132480

just-a-node commented 1 month ago

Refund processing? @ekbainova to determine this

ekbainova commented 3 weeks ago

Did we fix it with refactoring updates? @just-a-node @jwtong