search

connext / vector

↗️ Vector is an ultra-minimal state channel network implementation.
MIT License
109 stars 44 forks source link

Confirmation patch #657

Open jakekidd opened 3 years ago

jakekidd commented 3 years ago

The Problem

Nonce has expired, but sometimes takes longer than 45 sec to confirm. Results in a UI/UX issue - the tx eventually goes through, but our store/application state does not reflect it.

The Solution

Sledgehammer fix for issue where nonce expired, and we re-check for confirmation. Wait for an extended period when nonce has expired.

Also added some good juicy logs in there (and removed a redundant "Tx submitted." log)

jakekidd commented 3 years ago

Can't repro the issues/failures in the CI for this. The only additional functionality I added was the additional argument for the waitForConfirmation. Any insight welcome

sanchaymittal commented 3 years ago

Can't repro the issues/failures in the CI for this. The only additional functionality I added was the additional argument for the waitForConfirmation. Any insight welcome

Just wanted to let you know, waitForConfirmation didn't work at the frontEnd. I had to add tx.wait() to make things work.