search

connor135246 / Simply-Hot-Springs

GNU General Public License v3.0
1 stars 1 forks source link

Riptide doesn't activate in Hot Spring Water #14

Open KazuMurako opened 8 months ago

KazuMurako commented 8 months ago

Mod version: 0.3.0 Minecraft version: 1.19.2 Forge version: 43.2.4 Trident with riptide does not activate in Hot Spring Water. Is this intended behavior or a missing feature?

connor135246 commented 8 months ago

This is not something I can reasonably fix. Unfortunately, Forge's 1.19 fluid overhaul leaves a lot to be desired. It was apparently created with the goal of allowing more configurability, but ironically makes it harder to create a fluid that behaves similarly to vanilla water. They moved many water fluid behaviors that previously used to work with any fluid in the water tag to only work specifically with vanilla minecraft water.

Here's a list of some of the behaviors that you may expect of Hot Spring Water, but don't actually work: https://github.com/connor135246/Simply-Hot-Springs/blob/b34d8a25d3cab8a1deb6160ba153257ad1dd1e66/src/main/java/connor135246/simplyhotsprings/SimplyHotSprings.java#L31-L48

KazuMurako commented 8 months ago

Does NeoForged fix these issues in More recent MC versions?

connor135246 commented 8 months ago

Maybe. I haven't tried using NeoForged. Personally I'm just not interested in porting this mod to newer versions at the moment.