connor4312 / nodejs-testing

VS Code integration for node:test native tests
MIT License
43 stars 6 forks source link

accept ts-files and push --loader tsx #13

Closed jngross95 closed 10 months ago

jngross95 commented 11 months ago

I use the node test runner with typescript files without explicitly translating the files to js.

The files are only translated when executed.

I think your plugin is great. So it would be nice if it could also process ts files without having to translate them to js.

That's why I created the pull request.

The changes have no effect when the plugin processes js files

jngross95 commented 11 months ago

Note: I couldn't work with the "nodejs-testing.nodejsParameters" parameter, because these parameters are not passed to the spawn, that runs the unit test.

jngross95 commented 10 months ago

Thank you for the feedback. I have added prettier as a script in the package.json, as well as in the dev dependencies. Now the package.lock also matches the version.

connor4312 commented 10 months ago

Thanks for the followup! With the last change to add that check this should be good to go 🙂

jngross95 commented 10 months ago

thanks:-)