Closed rluvaton closed 4 months ago
Fixed conflicts
Thanks! The loss of monospace is unfortunate, I wonder if we can bring it back in markdown, maybe by wrapping the contents in a pre
or code
tag?
Regarding the trusted HTML and escaping, looking at vscode source code it handle the sanitize and escaping and protect from XSS
Yea, but the test output could still include HTML (e.g. tests for a library that does anything with HTML) which should be rendered as text and not interpreted as HTML
Thanks, will add test but making the output with monospace worked + using the css variables, thanks
also, great catch with the HTML that should be escaped
fixed the comments but still need to add tests, updated the image in the pr description to show the updated output
Hi, thanks again for the PR.
I actually got another request for this on VS Code. Since this is a fairly common problem and the solution is (as demonstrated) kind of hard to get right for extensions, I have made a change in VS Code to respect and colorize ANSI sequences automatically https://github.com/microsoft/vscode/pull/207852
Again, I really appreciate you taking the time to contribute this! I'm sorry it didn't end up getting this way.
Thank you! It's even better
Fixes #27
Todo
Before:
After: