connor4312 / nodejs-testing

VS Code integration for node:test native tests
MIT License
43 stars 6 forks source link

add envFile support for test runner #30

Closed uwinkelvos closed 4 months ago

uwinkelvos commented 4 months ago

Unfortunately using "--env-file" does not seem to be work with worker threads. Therefore to enable passing a test env to your tests, the new envFile and env settings can be set in the workspace settings. This is then in line with vscode launch configurations.

uwinkelvos commented 4 months ago

Hey @connor4312! In the first place thanks a lot for this extension! :) Wdyt about this feature in general? I saw that you did quite some refactoring with #31. Should I rebase my branch against that?

uwinkelvos commented 4 months ago

Rebased. Feel free to reach out with any suggestions @connor4312 .

connor4312 commented 4 months ago

Lgtm, thanks for the PR!