search

connorgallopo / leslies-pool

HomeAssistant Custom Integration for Leslies Pool water test results
MIT License
3 stars 0 forks source link

Two Feature Requests #29

Open ShakataGaNai opened 3 months ago

ShakataGaNai commented 3 months ago

Two hopefully simple feature requests. 1 - Name the sensors more descriptive than just their values. Like instead of "sensor.free_chlorine" it's "sensor.leslies_free_chlorine" - This is mostly just for collision purposes. Right now I've got WaterGuru, PoolMath and Leslies integrations, and they all have similar named sensors. 2 - Include a "last tested" value. It'd be nice to both know and set automations to remind myself to take water to the store for further testing. 3 - (Bonus?) In Store vs At Home notation. I don't have the home device, but it seems like you might and that data works as well. Might be good to know which data is which.

connorgallopo commented 3 months ago

Thanks! I want to address these individually just to see if we are in alignment but also to jot down some of my thoughts before I step away for the weekend:

  1. This is an easy change and ill shoot to have this in early next week!
  2. Without looking I'm pretty confident the first is the test date - so should be pretty easy as well! The one thing I would like to also do is use that date as the timestamp for the data points coming in, it would look less like a "polled" device but would be more historically accurate when compared to Leslie's. What do you think @ShakataGaNai?
  3. Similar with above, haven't looked but I'm pretty certain there is something on the record that would be able to tell us if it's at-home or in-store! Ill update when I have more details!
ShakataGaNai commented 3 months ago

Polled device would be cool. One of the things I tried doing was setting a footer in the cards that was FC or PH (example below). As none of the integrations I have track that data over time, it's the most boring graph ever. I think polled device would solve that?

image