connorjoleary / DeepCite

Traversing links to find the deep source of information
GNU General Public License v3.0
69 stars 7 forks source link

Popup Error Messages are HTML Instead of Text #50

Open panzey opened 4 years ago

panzey commented 4 years ago

When we receive an error message from the server to display in the popup extension, we should be receiving strictly text. Instead, we are receiving formatted HTML. This forces us to use .innerHTML instead of .value or .innerText, opening the gates for potential cross-site scripting attacks. We should only receive text to display to the user so we don't have to use this.

Steps to reproduce:

  1. type invalid claim and link
  2. hit the 'Cite' button

Expected results:

Actual results: