connorlay / tree-sitter-eex

EEx grammar for Tree-sitter
9 stars 3 forks source link

`<%!-- .. --%>` style comments #3

Closed the-mikedavis closed 2 years ago

the-mikedavis commented 2 years ago

While looking through the tokenizer I saw this come up: https://github.com/elixir-lang/elixir/pull/11505

Looks like <%!-- ... --%> is becoming the new <%# ... %>. I think this helps the case where you want to comment out some directives from (h)eex, since the terminating token is different than %>.

Based on this comment (https://github.com/elixir-lang/elixir/blob/0774e4c3854ba2a3894ba0fb1de29defe747345d/lib/eex/lib/eex/tokenizer.ex#L60) it looks like <%# ... %> becomes deprecated in elixir 1.18, so I think tree-sitter-eex should support both for the foreseeable future.