Fixing bug in case evlr offset is missing

connormanning / entwine

Entwine - point cloud organization for massive datasets

https://entwine.io

Other

451 stars 128 forks source link

Fixing bug in case evlr offset is missing #219

Closed nicolas-chaulet closed 5 years ago

nicolas-chaulet commented 5 years ago

evlr offset is currently missing from laz files written by PDAL. This PR ensures that they are ignored if missing.

connormanning commented 5 years ago

Thanks for this. This change seems fine to me as a safeguard, but does that mean PDAL is writing an invalid header? It doesn't seem like a valid file would have a non-zero EVLR number with an EVLR offset of zero. If so, can you ticket this upstream to PDAL itself for that aspect?

nicolas-chaulet commented 5 years ago

Yes PDAL writes a non valid header... EVLR offset was never set -> https://github.com/PDAL/PDAL/pull/2823

connormanning commented 5 years ago

Ah I missed that PR - thanks!