gtest 1.8.0 is old

[hobu]

This no longer compiles with newer MSVC. Please update gtest to 1.10.0 or better.

[defaultbranch]

@hobu

• I think this ticked is outdated for the master branch, today that already ships googletest-release-1.10.0
• but today on some Linux, the Linux GNU Compiler GCC 11.2.1 rejected that version 1.10 of googletest,

In file included from /entwine/test/googletest-release-1.10.0/googletest/src/gtest-all.cc:42:
/entwine/test/googletest-release-1.10.0/googletest/src/gtest-death-test.cc: In function 'bool testing::internal::StackGrowsDown()':
/entwine/test/googletest-release-1.10.0/googletest/src/gtest-death-test.cc:1301:24: error: 'dummy' may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~

• and I believe that (these days) it is bad practice to copy upstream library code into a project, because this makes it hard or impossible to track/keep up to date with upstream changes
  • did you consider to pull in googletest either as a git submodule (pulled in by git), or as some cmake dependency (pulled in by cmake)?

[connormanning]

This has been done, gtest is now updated to v1.13.0.