search

connormanning / entwine

Entwine - point cloud organization for massive datasets
https://entwine.io
Other
441 stars 129 forks source link

fixes building against PDAL >v2.3.0 #276

Closed rcoup closed 2 years ago

rcoup commented 2 years ago

This is an expansion of https://github.com/connormanning/entwine/pull/275 to add configure-time detection of the new API to cmake for both forward and backward compatibility with the PDAL LAS refactoring from https://github.com/PDAL/PDAL/commit/dd00e3a7. Tested with 2.3.0 and main@3b2942b

Related: https://github.com/PDAL/PDAL/issues/3677

/cc @abellgithub

hobu commented 2 years ago

Thanks for the updates. We added back the old API, so this gives us options as to how to move forward.

hobu commented 2 years ago

The failure is an unrelated thing due to this repo needing an update in regard to its Conda configuration.

rcoup commented 2 years ago

Closing this in light of https://github.com/PDAL/PDAL/pull/3682

Entwine builds now against PDAL master, though with C++ version warnings