search

connormanning / entwine

Entwine - point cloud organization for massive datasets
https://entwine.io
Other
451 stars 128 forks source link

CMake breaks when Backtrace is not available #282

Closed defaultbranch closed 2 years ago

defaultbranch commented 2 years ago

Current Behavior

If ./cmake/backtrace.cmake fails to find package "Backtrace", the CMake tool complains about usage of the undefined variable ${Backtrace_LIBRARIES} in ./app/CMakeLists.txt, and consequently the project cannot be built.

Expected Behavior

"Backtrace" is declared as an optional dependency. It should be possible to build the project, using CMake, when "Backtrace" is not provided.

Background

I try to build the project on Alpine Linux 3, "Backtrace" is not available in the Alpine package repository.

FYI I will send a small PR with a proposed fix soon.

defaultbranch commented 2 years ago

@connormanning thanks for the merge; will you close this issue, or should I do it?