connornishijima / Pixie_Chroma

Arduino library and documentation for Pixie Chroma displays!
https://lixielabs.com/chroma/
MIT License
53 stars 9 forks source link

write_pix(char*) should never modify cursor position #13

Closed github-actions[bot] closed 2 years ago

github-actions[bot] commented 2 years ago

write_pix(char*) should never modify cursor position

Use an internal offset (+user offset) to place chars instead

https://github.com/connornishijima/Pixie_Chroma/blob/a28e1f75466172cfb5ea62be1736bb713ec89051/src/pixie_chroma_internal.cpp#L746


    uint8_t len = strlen(message);
    for(uint8_t i = 0; i < len; i++){
        if(message[i] == '\n'){ // Newline, force line break
            // TODO: write_pix(char*) should never modify cursor position
            // Use an internal offset (+user offset) to place chars instead
            cursor_x = 1;
            cursor_y += display_height;

2407e2abeaaa4a8ad6e10bc58f2789270fbf7c13

github-actions[bot] commented 2 years ago

Closed in 53296056cbd58874dbf103f998b0f856d540037e