search

connorourke / crystal_torture

crystal_torture: A crystal structure analysis code, allowing site tortuosity to be calculated.
MIT License
7 stars 2 forks source link

pip install numpy issue #3

Closed mkhorton closed 5 years ago

mkhorton commented 5 years ago

Just a small note: because you use numpy in the setup.py pip install crystal_torture will not work in a clean virtual environment (ie without numpy already pre-installed); it might be worth making a note of this in the readme. This can also cause problems were crystal_torture to be listed in the requirements.txt of another package.

mkhorton commented 5 years ago

(I'm not sure if this is related to the other open issue when I saw mentioned that a pip install does work in a clean venv. My example of this not working is with Python 3.7.0 and pip 10.0.1 and also pip 19.0.3).

bjmorgan commented 5 years ago

This should be fixed in commit https://github.com/connorourke/crystal_torture/commit/10ae09a65a7d9641cd30f161315720f52252b46d.