connors / photon

The fastest way to build beautiful Electron apps using simple HTML and CSS
photonkit.com
MIT License
10.01k stars 579 forks source link

Starting template application - "Error: Cannot find module 'app'" #111

Open radhewro opened 8 years ago

radhewro commented 8 years ago
  1. Downloaded "dist" zip
  2. Unzipped
  3. Opened terminal, cd to the folder "template-app"
  4. Run "electron ."
  5. Got an error: "Error: Cannot find module 'app'"

I've debuged in vs.code too, the first require("app") throws that exception.

Electron-prebuild is installed via npm/nvm.

What I'm doing wrong?

scholtzm commented 8 years ago

Seems like you are using Electron v1.x and template app uses older version of Electron APIs.

radhewro commented 8 years ago

Thank you.

radhewro commented 8 years ago

Ah, one more question: do you have any idea how to fix/workaround it?

gadget00 commented 8 years ago

So far, you have to re-write the code of Photon so it complies with the new syntax of Electron 1.x

scholtzm commented 8 years ago

You could also use older version of Electron, but I would advise against that.

radhewro commented 8 years ago

Oh, sad...thank you all!

zephyrzoom commented 8 years ago

It also happend to me!

arjunmenon commented 8 years ago

Spent more than an hour to finding out the cause. Was actually frustrating. This seems like a common issue. Can the author put up a guide on re-writing the Photon to work with newer stable versions?

sercheo87 commented 8 years ago

The error is solvent with replace the next section in file app.js

var app = require('app'); // Module to control application life. var BrowserWindow = require('browser-window'); // Module to create native browser window.

with

const {app, BrowserWindow} = require('electron');

samuelyeshua commented 8 years ago

117 This was solved in this pull request