search

connors / photon

The fastest way to build beautiful Electron apps using simple HTML and CSS
photonkit.com
MIT License
10.01k stars 580 forks source link

Marks derived files as binaries #15

Closed rjz closed 6 years ago

rjz commented 8 years ago

We may not want these checked in at all, but while they're still in the index we can at least exclude them from git-diff.

jeroenvisser101 commented 8 years ago

:+1:, It looks to me like you have 2 trailing newlines, but that could be me

rjz commented 8 years ago

Just one newline, and we should keep it.

Thanks, @jeroenvisser101!

jeroenvisser101 commented 8 years ago

I know about trailing lines, but github hides it if it's there. However, it seems here are 2:

rjz commented 8 years ago

Alright, removed the explicit newline—guessing the screenshotted editor still shows an extra one?

jeroenvisser101 commented 8 years ago

Yes, and if it would be missing, a red icon indicating it's missing would appear, this looks great :+1:

connors commented 8 years ago

@rjz Thanks dude. Before merging this in, can you give me a quick rundown of what the benefit of this is? Not sure why we'd need this.

rjz commented 8 years ago

Sure! Since the dist/* files are derived from other sources (sass), marking these files binary will let us get away without reviewing (or resolving merge conflicts in) the generated output.

A next step might be to discourage check-ins of built files entirely, or to avoid them in PRs and automate a rebuild when new changes drop into master instead.