Closed rjz closed 6 years ago
:+1:, It looks to me like you have 2 trailing newlines, but that could be me
Just one newline, and we should keep it.
Thanks, @jeroenvisser101!
I know about trailing lines, but github hides it if it's there. However, it seems here are 2:
Alright, removed the explicit newline—guessing the screenshotted editor still shows an extra one?
Yes, and if it would be missing, a red icon indicating it's missing would appear, this looks great :+1:
@rjz Thanks dude. Before merging this in, can you give me a quick rundown of what the benefit of this is? Not sure why we'd need this.
Sure! Since the dist/*
files are derived from other sources (sass), marking these files binary will let us get away without reviewing (or resolving merge conflicts in) the generated output.
A next step might be to discourage check-ins of built files entirely, or to avoid them in PRs and automate a rebuild when new changes drop into master instead.
We may not want these checked in at all, but while they're still in the index we can at least exclude them from
git-diff
.