connors / photon

The fastest way to build beautiful Electron apps using simple HTML and CSS
photonkit.com
MIT License
10.01k stars 580 forks source link

Table headers active #18

Closed iamphill closed 9 years ago

iamphill commented 9 years ago

When you click on the thead cell, instead of just highlighting the clicked cell, it highlights the whole row

mszynka commented 9 years ago

Are you using 'thead' for column or row header? If for row header it's intentional and intuitive to have highlighted whole row with content.

iamphill commented 9 years ago

So the demo app looks to represent a file browser like finder on mac and when clicking on the cell in the header it makes the whole row active (fine for the body). But for the header it should only highlight the cell.

Doing it this way would resemble how finder (and I'm sure explorer) does it - by only highlight the selected header cell, not the row.

Does that make more sense?

damianstasik commented 9 years ago

Noticed the same thing, full support.

mszynka commented 9 years ago

@iamphill yes it does. It should highlight whole column. That's a legit issue. +1

iamphill commented 9 years ago

Looks like this was fixed by f6552970cd9d68548deb427e43df8d0d816fe8f1