Need the panes to be resizable

connors / photon

The fastest way to build beautiful Electron apps using simple HTML and CSS

photonkit.com

MIT License

10.01k stars 579 forks source link

Need the panes to be resizable #91

Open bibhas2 opened 8 years ago

bibhas2 commented 8 years ago

We need the panes to be resizable using some kind a splitter. I tried using jQuery Splitter without much luck.

psunnn commented 8 years ago

@connors @bibhas2 Would something like this work? This would allow pane resizing, deeply nested panes/pane-groups, and vertical pane-groups (thus solving #92 as well). Wrote it in pure JavaScript so no jQuery needed. Let me know and I'll create a PR.

resize

bibhas2 commented 8 years ago

That looks very good and will meet the needs. A few points:

The cursor needs to change when the mouse moves over the splitter.
The splitter seems too thin to me. I do realize that in Mac OS X a splitter is also very thin. Hopefully the thickness can be easily customized.
Hopefully the HTML markup for this will be as minimalistic and easy to use as the rest of the Photonkit components.

Please keep up the good work. So far this is the best toolkit out there for desktop development.

psunnn commented 8 years ago

Thanks for the feedback - I'll definitely take your thoughts into consideration. The HTML markup itself will be pretty much the same with the exception of vertical pane groups and won't break anything you've already built :)

vasyl-shumskyi commented 7 years ago

Really nice! Unfortunately wasn't able to make this work

screen shot 2017-05-09 at 11 47 32

MauriceConrad commented 7 years ago

Look at https://github.com/MauriceConrad/PhotonKit-Components

There is a solution that changes the cursor and still works out of the box without initializing