connors511 / dinto-issues

Public issue tracker for https://din.to
0 stars 0 forks source link

Transaction that brings deleted members' balance to zero has type "deposit" #47

Closed jonaslb closed 7 years ago

jonaslb commented 7 years ago

And I guess it would have type "withdraw" the value had different sign.

As background, I think that it is a good principle, that the sum of withdraw and deposit transactions should give the change of actual cash in the treasurebox. However that is not the case the way dinto closes accounts.

For example I just closed someone's membership: First, I created a withdrawal of xxx, bringing them to the balance -0.1kr (not possible to do in cash). Then i closed the account. That automatically created a "deposit" transaction of 10øre. This gives the wrong impression that the person actually paid this amount!

The transaction should just have the type "transaction" or something else which correctly implies that the amount is taken as a "loss" (or "gain" if it had opposite sign) for the community. The message/note on the transaction could be "From the community".