search

connorshea / vscode-ruby-test-adapter

A Ruby test adapter extension for the VS Code Test Explorer
https://marketplace.visualstudio.com/items?itemName=connorshea.vscode-ruby-test-adapter
MIT License
83 stars 50 forks source link

Minitest nested #37

Closed baelter closed 4 years ago

baelter commented 4 years ago

Support nested minitests, branched from #34

Fixes #21

connorshea commented 4 years ago

Thanks! I'll test and review this in the next few days, please @ me if I haven't reviewed this or your other PR by Friday. :)

baelter commented 4 years ago

@connorshea

baelter commented 4 years ago

@connorshea :)

connorshea commented 4 years ago

Hmm, I get this error when trying this PR on my Rails app w/ minitest:

notificationsAlerts.ts:40 Command failed: bundle exec rake -R $EXT_DIR vscode:minitest:list rake aborted! KeyError: key not found: "TESTS_PATTERN" Did you mean?  "TESTS_DIR" /Users/connorshea/Programming/vscode-ruby-test-adapter/ruby/vscode/minitest/tests.rb:22:in `fetch' /Users/connorshea/Programming/vscode-ruby-test-adapter/ruby/vscode/minitest/tests.rb:22:in `load_files' /Users/connorshea/Programming/vscode-ruby-test-adapter/ruby/vscode/minitest/tests.rb:6:in `all' /Users/connorshea/Programming/vscode-ruby-test-adapter/ruby/vscode/minitest.rb:25:in `list' /Users/connorshea/Programming/vscode-ruby-test-adapter/ruby/vscode.rake:8:in `block (3 levels) in <top (required)>' /Users/connorshea/.rbenv/versions/2.5.3/bin/bundle:23:in `load' /Users/connorshea/.rbenv/versions/2.5.3/bin/bundle:23:in `<main>' Tasks: TOP => vscode:minitest:list (See full trace by running task with --trace)
connorshea commented 4 years ago 
[2020-02-12 18:33:08.535] [renderer10] [error] Command failed: bundle exec rake -R $EXT_DIR vscode:minitest:list
rake aborted!
KeyError: key not found: "TESTS_PATTERN"
/Users/connorshea/Programming/vscode-ruby-test-adapter/ruby/vscode/minitest/tests.rb:23:in `fetch'
/Users/connorshea/Programming/vscode-ruby-test-adapter/ruby/vscode/minitest/tests.rb:23:in `load_files'
/Users/connorshea/Programming/vscode-ruby-test-adapter/ruby/vscode/minitest/tests.rb:6:in `all'
/Users/connorshea/Programming/vscode-ruby-test-adapter/ruby/vscode/minitest.rb:25:in `list'
/Users/connorshea/Programming/vscode-ruby-test-adapter/ruby/vscode.rake:8:in `block (3 levels) in <main>'
/Users/connorshea/.rbenv/versions/2.6.5/bin/bundle:23:in `load'
/Users/connorshea/.rbenv/versions/2.6.5/bin/bundle:23:in `<main>'
Tasks: TOP => vscode:minitest:list
(See full trace by running task with --trace)
: Error: Command failed: bundle exec rake -R $EXT_DIR vscode:minitest:list
rake aborted!
KeyError: key not found: "TESTS_PATTERN"
/Users/connorshea/Programming/vscode-ruby-test-adapter/ruby/vscode/minitest/tests.rb:23:in `fetch'
/Users/connorshea/Programming/vscode-ruby-test-adapter/ruby/vscode/minitest/tests.rb:23:in `load_files'
/Users/connorshea/Programming/vscode-ruby-test-adapter/ruby/vscode/minitest/tests.rb:6:in `all'
/Users/connorshea/Programming/vscode-ruby-test-adapter/ruby/vscode/minitest.rb:25:in `list'
/Users/connorshea/Programming/vscode-ruby-test-adapter/ruby/vscode.rake:8:in `block (3 levels) in <main>'
/Users/connorshea/.rbenv/versions/2.6.5/bin/bundle:23:in `load'
/Users/connorshea/.rbenv/versions/2.6.5/bin/bundle:23:in `<main>'
Tasks: TOP => vscode:minitest:list
(See full trace by running task with --trace)

    at ChildProcess.exithandler (child_process.js:303:12)
    at ChildProcess.emit (events.js:200:13)
    at maybeClose (internal/child_process.js:1021:16)
    at Socket.<anonymous> (internal/child_process.js:430:11)
    at Socket.emit (events.js:200:13)
    at Pipe.<anonymous> (net.js:586:12)

From trying to load the tests in https://github.com/connorshea/mdn-compat-data-explorer

connorshea commented 4 years ago

Oh, I may have forgotten to run the watch task and that's why it wasn't working 🤦‍♂ My bad.

connorshea commented 4 years ago

Regardless, I think you've waited long enough so I'll merge this. Thank you for the patience! :)

baelter commented 4 years ago

Looks good to me. Only thing I'm not clear on is how the tests in ruby/ work? Are they for manually testing the extension?

Yes, I just open them in vscode to verify that all looks ok.