connorshea / vscode-ruby-test-adapter

A Ruby test adapter extension for the VS Code Test Explorer
https://marketplace.visualstudio.com/items?itemName=connorshea.vscode-ruby-test-adapter
MIT License
83 stars 50 forks source link

Quote test location argument when running tests #42

Closed noniq closed 4 years ago

noniq commented 4 years ago

Fixes #41

It's only a workaround though and will not work for all cases (correctly escaping shell arguments is near to impossible).

A proper fix would be to not use a shell at all when starting the test process. I created a PoC here: https://github.com/noniq/vscode-ruby-test-adapter/commit/d11dd60b798a8ed0108f4e9e80fac6b1ce026a72 However, as mentioned in the commit message, this is prone to break some of the more exotic setups.

connorshea commented 4 years ago

Thanks! It looks like minitest has the same problem, but I can fix that myself in a separate commit.