Supply file and line number to failed TestEvent

connorshea / vscode-ruby-test-adapter

A Ruby test adapter extension for the VS Code Test Explorer

https://marketplace.visualstudio.com/items?itemName=connorshea.vscode-ruby-test-adapter

MIT License

85 stars 52 forks source link

Supply file and line number to failed TestEvent #49

Closed emilyst closed 4 years ago

emilyst commented 4 years ago

When the TestEvent fires, it may contain a file name and a line number to suggest where the event took place.

This commit adds the file name and line number to the TestEvent and to its TestDecoration.

emilyst commented 4 years ago

Opened to help me with https://github.com/hbenl/vscode-test-explorer/issues/136.

connorshea commented 4 years ago

Does this require changes in the Test Explorer UI extension to work or will it work without them?

emilyst commented 4 years ago

Does this require changes in the Test Explorer UI extension to work or will it work without them?

These fields exist in Test Explorer UI since version 1.8.0, released about three months ago (directly after this commit).

emilyst commented 4 years ago

It occurs to me I might need to update package.json to require 1.8.0 due to my previous comment. I'm running the extension in the debugger now to make sure it works.

emilyst commented 4 years ago

I have amended the commit to make two changes.

I have required the version 1.8.0 of vscode-test-adapter-api which contains the fields on which I rely.
I have stopped setting the file and line field on the TestEvent itself. It appears that setting the TestEvent fields this way signals that the Test Explorer UI should look for the test in a different place after running, causing some confusion. It's really only necessary to set it on the TestDecoration for my purpose.

emilyst commented 4 years ago

It's likely this pull request is entirely unneeded, per further discussion here.