search

connortechnology / ZoneMinder

ZoneMinder is a free, open source Closed-circuit television software application developed for Linux which supports IP, USB and Analog cameras.
http://www.zoneminder.com/
GNU General Public License v2.0
9 stars 9 forks source link

move eventvideo div close #33

Closed digital-gnome closed 6 years ago

digital-gnome commented 6 years ago

I think I did this. eventVideo div wasn't properly wrapping everything. Sorry.

connortechnology commented 6 years ago

I'm not sure this is right either.

digital-gnome commented 6 years ago

It's possible I copied wrong. Something was a little strange before I pushed. I'll double check

On Oct 12, 2017 5:51 PM, "Isaac Connor" notifications@github.com wrote:

I'm not sure this is right either.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/connortechnology/ZoneMinder/pull/33#issuecomment-336284106, or mute the thread https://github.com/notifications/unsubscribe-auth/AeIT_hLyeDVr4kINnbIzWGamba-m32Drks5sronogaJpZM4P3q3t .

digital-gnome commented 6 years ago

It's the same current zoneminder master. It encloses everything except if ($Event->SaveJPEGs() & 3).

digital-gnome commented 6 years ago

It doesn't really do anything that I can see but it either needs this fix or the opening tag needs to be in the video.js if block. Currently it's a weird empty div above zms streams.

digital-gnome commented 6 years ago

Updated pull request. It's used for the showStills button with the eventStills stuff. I can't get that to trigger on mine but it hides eventVideo and imageFeed. Currently all zoneminders with the h264 feature incorporated have this technically wrong but it doesn't really matter. This makes it match what the javascript thought it looked like.