conor19w / Binance-Futures-Trading-Bot

A Technical Analysis Bot that trades leveraged USDT futures markets on Binance.
539 stars 177 forks source link

Is this line correct? #24

Closed eternauta123 closed 2 years ago

eternauta123 commented 2 years ago

https://github.com/conor19w/Binance-Futures-Bot/blob/a962a0d9505b1c2afcd0f4ec53cdbbd13074d41e/Bot_Class.py#L140

Is this line correct? Or should it be referencing -1 index on OPEN_H? It is an append statement so for example: Close_H length =300 Open_H length =300 self.Close_H.append((self.Open[-1] + self.Close[-1] + self.Low[-1] + self.High[-1]) / 4) Close_H length =301 Open_H length =300 Current: self.Open_H.append((self.Open_H[-2] + self.Close_H[-2]) / 2)-> self.Open_H.append((self.Open_H[-299] + self.Close_H[-300]) / 2) What may be the correction: self.Open_H.append((self.Open_H[-1] + self.Close_H[-2]) / 2) -> self.Open_H.append((self.Open_H[-300] + self.Close_H[-300]) / 2)

Close_H length =301 Open_H length =301

conor19w commented 2 years ago

Looked into issue with heikin ashi and fixed it through trial and error, should be good now I printed out values and compared to Binance's Prices. Your solution worked but I still don't get why I didn't have to alter the logic in add_hist() as I should run into the same issue... Thanks for the help

eternauta123 commented 2 years ago

Connor, I am quite new on github collaboration I forked your project, but accidentally uploaded some paswords so i deleted it.

I wanted to make some pull requests, bit now is so different in some stuff and i am just testing what i am really usingn that I am afraid I won’t.

I will share my project with you.

The main I implemented that you may use is:

Thank you very much!

Sent from my iPhone

On 21 Jun 2022, at 23:42, Conor White @.***> wrote:

 Looked into issue with heikin ashi and fixed it through trial and error, should be good now I printed out values and compared to Binance's Prices. Your solution worked but I still don't get why I didn't have to alter the logic in add_hist() as I should run into the same issue... Thanks for the help

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.