Remove jQuery - Githubissues

conorgil / 2fa-notifier

2FA Notifier is a web extension that notifies users whether or not the sites they visit support two factor authentication (2FA).

https://2fanotifier.org

MIT License

41 stars 7 forks source link

Remove jQuery #65

Closed domoritz closed 5 years ago

domoritz commented 6 years ago

I love the extension and read through the code. I noticed that you could probably go without jQuery to save resources.

http://youmightnotneedjquery.com/ is a great guide.

conorgil commented 6 years ago

@domoritz totally agree. We threw in jQuery because it was quick and required less thinking. There is a ton of cleanup that we plan to do and removing jQuery is certainly something to look at. Thanks for checking it out!

domoritz commented 6 years ago

Sweet. Make it work, make it right, make it fast.

conorgil commented 6 years ago

A friend just shared this article with me and I am bumping up the priority of removing jQuery as a result.

Benefits:

smaller extension package size
less code to audit/review (no, I didn't audit/review jQuery source, but that is kinda the point...)
many others I'm sure

conorgil commented 6 years ago

Looks like removing jQuery shaved 80kb off the extension package size. Huzzah!

conorgil commented 5 years ago

We ended up saving 67kb: reduced package size from 540kb to 473kb