conorpp / u2f-zero

U2F USB token optimized for physical security, affordability, and style
Other
2.41k stars 200 forks source link

Fixed BOM xsl to properly generate CSV #81

Closed krayon closed 6 years ago

krayon commented 6 years ago

The BOM xsl generated invalid CSV due to commas in manufacture names. This is even evident if you try to view the CSV in Github as it reports wrong field lengths.

This PR fixes this by quoting those fields that contain commas and also by correctly escaping any quoted fields with quotes themselves as per RFC 4180 ( http://www.ietf.org/rfc/rfc4180.txt ).

Lastly, the debug pins were being included so I excluded any entries without the extra field parameters.

conorpp commented 6 years ago

Good catch, thank you!