conorpp / u2f-zero

U2F USB token optimized for physical security, affordability, and style
Other
2.41k stars 200 forks source link

[WIP] Fix 1kB ping crash #83

Open szszszsz opened 6 years ago

szszszsz commented 6 years ago

Following patch should fix #67 (crash on 1kB ping message). Changes:

Porting fix from Nitrokey/nitrokey-fido-u2f-firmware, where it was tested. Not tested on U2F-Zero hardware. For solution-related questions please ask @adamglozik directly.

WIP prefix added, since the build (tested on Simplicity Studio v3 / Keil v9.53, ATECC_SETUP_DEVICE not defined) is blocked due to an unrelated compilation error for u2f_printx disabling macro (see TOFIX prefixed commit), which needs correction (ideally by removing TOFIX commit and applying chosen approach with the macros).

Edit 20180709: added missing brace and removed TOFIX commit.

Fixes #67

CC: @adamglozik @jans23

szszszsz commented 6 years ago

I have added missing brace and removed TOFIX commit.