rconshell does not notice server going away

conqp / rcon

Python RCON client library

GNU General Public License v3.0

83 stars 15 forks source link

rconshell does not notice server going away #16

Closed miiichael closed 1 year ago

miiichael commented 1 year ago

Probably applies to the other clients too. Steps to reproduce:

connect to any Minecraft server with rconshell
stop the server (eg. by sending a stop command)
wait for server to stop
note that rconshell does not notice that the connection to server is now in CLOSE_WAIT state (until you try to send a command)

Expected behaviour:

rconshell to exit or complain when the connection to the server is closed

rcon 2.3.6 from Debian.

conqp commented 1 year ago

For that to happen, the RCON shell would need to constantly need to check the connection i.e. via a keepalive packet, which RCON does not support. I'm open to suggestions.

miiichael commented 1 year ago

No, keepalive packets are not necessary here; if the server closes the connection, clients should be able to notice straight away.

Whoops, I wrote my own RCON client. :sweat_smile: mini-rcon-cli.txt