collaboration query - Githubissues

PawelSpoon commented 8 months ago

Hello, i would like to extend tidalplayer with items from homescreen. not sure what python-tidal does support but it seems i could show some categories. i would be interested in: Recently played Suggested new albums Your history ideally i can open an album i did play in the last week, that might be definately possible. second point would be to browse my fav albums and play one or open an fav artist, pick an album and play it. that would be completely fine with me. i just took latest python-tidal and do play around with the api. i have also forked your repo. but two questions first: a) would you accept a pull request ? b) any preferences how i should bring in the functionality ? c) do you have any tests that are not there in the repo ? Regards Pawel

conradhuebler commented 8 months ago

Hi,

you are totally welcome to contribute. Just some things to begin.

Currently, I have only limited time while do not have sufficiant experience with QML, Python and JS. It is much more complicated than C++ with Qt ;-)
So there are some things I would like to figure out myself, before it is save to contribute. I just might change things as result of a learning process. Currently, uncommited are changes to the UI, that make it behave a bit like the PodQast app. During the process, I broke many playback and playlist stuff. I try to figure it out within the next days.
As far as I understand the tidal-python-interface, played tracks are not automatically tracked as played tracks. Unlike to the webinterface, so this has to be done manually. I haven't looked into API for that yet.

Cheers, Conrad

PawelSpoon commented 8 months ago

sounds good. i will wait for your next check-in and then we can talk. btw. i do maintain an app called squeeze-remote. it is a remote for logitech media server, that supports actually tidal plugin and supports most of tidals read-only features with only 3 different types of pages. i did not write it, just keeping it alive.

PawelSpoon commented 7 months ago

i know i nerve :D but summer is comming and my motivation will then go away till december. i would like to start with the python part on my side. did you change a lot here ?

conradhuebler commented 7 months ago

Hi,

sorry for not replaying earlier. There are so many non-sailfish things going on.

Well, first thing. I implemented a playlistmanager in python since each time the tidal-api resolves the track url, the app and webapp will stop playing. Hence I thought would be better to resolve the link only when the track is about to be played. But the playlistmanager is not working well. One could just use the QML Playlistmanager (for now). Then the app can at least be used to regular listening of music. And the second thing, I don't understand is the docked panel, which cant be interacted with (slider and prev and forward buttons).

The interface with the tidal-api itselfs is not the problem and can be extended without problems :-).

Currently I have nothing that is not synced with GH. And I have no pure QML tests - I know, bad thing. A QML player for the desktop would be a nice thing as well ...

Cheers, Conrad

PawelSpoon commented 7 months ago

i took over tidalapi python tests and try to adapt them to work with pyotherside. lets see if i succeed or fail

PawelSpoon commented 7 months ago

Hi,

i have now a super simple sample: https://github.com/PawelSpoon/TideIsHigh/blob/main/tests/qmltest/tst_TidalApi.qml

where i did extract tidalapi into a separated file and i am able to run tests against it. i can authenticate and i can read the playlists i would now start to implement some home-screen functions:

get my artists
get my albums
get recently played this stuff and maybe add / remove from favs.

those features would make me already pretty happy :D

conradhuebler / harbour-tidalplayer

collaboration query #1