search

conradkleinespel / rpassword

Cross platform Rust library to read a password in the terminal (Linux, BSD, OSX, Windows, WASM).
Apache License 2.0
244 stars 38 forks source link

Fix 23 #26

Closed teythoon closed 5 years ago

teythoon commented 6 years ago

This builds upon my previous patch series #25.

conradkleinespel commented 6 years ago

Hi @teythoon ! Thanks for this PR :+1: and sorry for the delay. I've been a bit busy these last few days, but I hope to have a closer look at this PR the coming weekend. I'll keep you posted either way. Cheers

conradkleinespel commented 6 years ago

Hi again @teythoon ! Looks good to me.

There seems to be a conflict after I merged your other PR #25 . Would you mind having a look at it ?

As soon as it's fixed, I can merge and publish to crates.io.

teythoon commented 6 years ago

There seems to be a conflict after I merged your other PR #25 . Would you mind having a look at it ?

Github folded my two commits into one when you merged #25. That is certainly annoying. I'll update this pull request.

As soon as it's fixed, I can merge and publish to crates.io.

Thanks!

conradkleinespel commented 5 years ago

Thanks @teythoon ! I'm having a look at this within 48 hours.

I really want to thank you for helping making this library better. Would you like to be a collaborator on the Github repo and co-owner of the crate on crates.io ? That might make future updates easier.

conradkleinespel commented 5 years ago

@teythoon Thanks again for this. Looks great ! I'm thinking we can probably remove all functions but read_password_from_tty before publishing to crates.io, since read_password_from_tty allows prompting and is better than reading straight from stdin. What do you think ?

conradkleinespel commented 5 years ago

@teythoon Or maybe we need to keep those functions for when no tty is available ?