search

conradkleinespel / rpassword

Cross platform Rust library to read a password in the terminal (Linux, BSD, OSX, Windows, WASM).
Apache License 2.0
244 stars 38 forks source link

Re-add windows support #5

Closed retep998 closed 9 years ago

retep998 commented 9 years ago

Reminder to myself to do this.

conradkleinespel commented 9 years ago

Hi @retep998,

Awesome to see you're still interested in this ! :+1:

I don't use Windows and have no Windows license so it's hard for me to support this platform. And I kinda had to drop Windows support since it was broken with rustc updates in the last few weeks. However, I will gladly merge a patch if you have and take the time to create it.

Take care, Conrad

equalsraf commented 9 years ago

Cheers, is anyone looking into this? I have a quick fix using the original source from #2, in here. Seems to work ok with Rust 1.0 here.

conradkleinespel commented 9 years ago

Hi @equalsraf,

Thanks a lot for your work ! :+1:

If you have a patch and make a working pull request, I'm glad to merge.

On that note, I'm a Mac/Linux user and don't have Windows. Would you be interested in getting commit access to maintain the Windows version ? Same question to you, @retep998, in case you're interested :-)

Cheers, Conrad

equalsraf commented 9 years ago

Honestly this is my first bit of public rust ever :grinning: and I don't spend that long in front of Windows, but I can give it a shot.

equalsraf commented 9 years ago

Incidentally if you want, it seems easy enough to enable CI builds for windows (well there are no tests for windows yet, but at least it builds the example).

conradkleinespel commented 9 years ago

Thanks a lot for your contribution @equalsraf !

This issue is resolved per: https://github.com/conradkleinespel/rustastic-password/commit/1b77c90aff38837b6e9b1b8b41e066cb2c6e5a81

conradkleinespel commented 9 years ago

I've updated the version and pushed it to crates.io.