search

conradkleinespel / rpassword

Cross platform Rust library to read a password in the terminal (Linux, BSD, OSX, Windows, WASM).
Apache License 2.0
244 stars 38 forks source link

Add windows support #6

Closed equalsraf closed 9 years ago

equalsraf commented 9 years ago

This commit reintroduces Windows support, based on the original Windows PR(#2), it builds in Windows using Rust 1.0.

For #5.

equalsraf commented 9 years ago

Build is failing I can't test this locally right now, but I'll fix it when I get some windows time.

retep998 commented 9 years ago

Update the dependency on winapi to 0.2.

conradkleinespel commented 9 years ago

Hi everyone,

Thanks again for your contributions.

I'm terribly sorry I haven't merged this yet. I have very little time for Rust-stuff at the moment. Again, if you are willing to maintain the Windows version of tihs library, let me know and I can give you commit rights.

Otherwise, I will definitely get to merging this, but it might take a little longer (I'm very busy until the end of July).

Best regards, Conrad

equalsraf commented 9 years ago

@retep998 thanks, that works. fixed now.

equalsraf commented 9 years ago

@conradkleinespel please add me them. I'll merge this and get some CI running to avoid breaking stuff.

I still don't have a strategy for windows unit testing though.

conradkleinespel commented 9 years ago

@equalsraf : Awesome ! I've added you as a collaborator so you should now have commit access. Please let me know if this is not the case.

conradkleinespel commented 9 years ago

@equalsraf: Also, once this is merged, feel free to add yourself to the list of contributors in the README.md in alphabetical order, if you want to. Every contributor deserves credit :-)

equalsraf commented 9 years ago

Moved the CI stuff out of this PR (here).

I'll have another look in a bit and If everything looks ok I'll merge this.

conradkleinespel commented 9 years ago

I've updated the version and pushed it to crates.io.