Fix a bug where the newline was not added on windows

conradkleinespel / rpassword

Cross platform Rust library to read a password in the terminal (Linux, BSD, OSX, Windows, WASM).

Apache License 2.0

244 stars 38 forks source link

Fix a bug where the newline was not added on windows #69

Closed NovaliX-Dev closed 2 years ago

NovaliX-Dev commented 2 years ago

When a user enter a password, if any io error occurs on the reader when reading a line, the new line is not added, and print! or println! will print on the same line.

conradkleinespel commented 2 years ago

Thanks for the fix :pray: will merge and publish to crates.io when I get a moment

conradkleinespel commented 2 years ago

Because I maintain things in another repository, I've copied your code here: https://github.com/conradkleinespel/duck/pull/36

I'm closing this PR and will merge the other one once the tests pass.

conradkleinespel commented 2 years ago

I've just published version v7.0.0 which includes this fix as well as another improvement, see: https://github.com/conradkleinespel/rpassword/releases/tag/v7.0.0

NovaliX-Dev commented 2 years ago

All right! Glad to had contributed !