search

conradsoon / pe

0 stars 0 forks source link

`addTutorial` does not allow me to add tutorials for timeslots like `MON 4:30pm` #13

Open conradsoon opened 11 months ago

conradsoon commented 11 months ago

addTutorial m/CS2100 tt/Mon 12:30pm tn/bnlah

image.png

However, there may be tutorials which do not start exactly at whole hours, and as such this is a feature flaw.

nus-pe-script commented 11 months ago

Team's Response

Thank you for pointing out the problem, this need fixing!

I intended to say the time of a tutorial should be an integer between 1 to 12, but i did not give enough description in the UG.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Format for 12_HOUR_CLOCK_TIME in addTutorial not specified in UG

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

image.png

As a user, I'm not sure how exactly to format the 12_HOUR_CLOCK_TIME in addTutorial due to lack of specification in the UG. For example, is 10.30PM allowed, or is 12:00PM allowed?

[original: nus-cs2103-AY2324S1/pe-interim#1628] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for pointing out the problem, this need fixing!

I intended to say the time of a tutorial should be an integer between 1 to 12, but i did not give enough description in the UG.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Hey, sorry for not being clearer in my original bug report, but I disagree with this being marked as a duplicate.

In the case of the bug report for Format for 12_HOUR_CLOCK_TIME in addTutorial not specified in UG, the main issue is that there isn't a clear way on how to format the 12_HOUR_CLOCK_TIME i.e. documentation is not too clear on this.

In this case, the main crux of the issue is more of an inability to support tutorials that start at non-integer hours, which means that the feature doesn't model all the behaviour I'd expect from it, which is different.

## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** Hey, sorry for not being clearer in my original bug report, but I disagree with this being marked as a documentation flaw (same as above). In the case of the bug report for `Format for 12_HOUR_CLOCK_TIME in addTutorial not specified in UG`, the main issue is that there isn't a clear way on how to format the 12_HOUR_CLOCK_TIME i.e. documentation is not too clear on this. In this case, the main crux of the issue is more of an inability to support tutorials that start at non-integer hours, which means that the feature doesn't model all the behaviour I'd expect from it, which is different.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]