conradsoon / pe

0 stars 0 forks source link

`modules` and `tutorials` at top do not include an index #14

Open conradsoon opened 11 months ago

conradsoon commented 11 months ago

Currently, the header showing modules and tutorials does not show an index. This means that if we want to find the index of a certain tutorial to reference, we have to manually count the modules and tutorials to find the index, which leads to a worsened user experience.

Additionally, given the fact that your addModule and addTutorial commands allow for names with spaces in them, this can lead to disambiguity.

Consider addTutorial m/CS2100 tn/CS2100 Mon 12pm tt/MON 12pm addTutorial m/CS2100 tn/Tue 12pm tt/Tue 12pm

image.png

In this case, it is unclear what index each tutorial occupies.

nus-se-bot commented 11 months ago

Team's Response

Severity Medium -> Low:

Given that most TAs don't teach many tutorials (usually less than 5) at the same time, manually counting the module and tutorial index is unlikely to be difficult enough to cause substantial inconvenience to the user.

The example given is extremely unlikely to occur to a end-user using this product because it uses tutorial names such as "CS2100 Mon 12pm" and "Tue 12pm" which create confusion because it includes the time given. Such names are extremely unlikely to be actual names of NUS tutorials, so they can be considered deliberate sabotage and should not be considered a bug.

(The system does not validate tutorial names to not violate overzealous input validation)

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]