conroylau / lpinfer

lpinfer: An R Package for Inference in Linear Programs
GNU General Public License v3.0
3 stars 5 forks source link

invertci and FSST #110

Closed nadavkun closed 3 years ago

nadavkun commented 3 years ago

Hi, While running inertci with the FSST command I get that a point is reject if $p<\alpha/2$. As far as I understand, a points needs to be rejected if $p<\alpha$.

I'm running, based on the example in the documentation

lpm <- lpmodel(A.obs = mixedlogit_Aobs(dgp),
               beta.obs = function(d) mixedlogit_betaobs(d, dgp),
               A.shp = rep(1, nrow(dgp$vdist)),
               beta.shp = 1,
               A.tgt = mixedlogit_Atgt_dfelast(dgp, w2eval = 1, eeval = -1))

invertci(f = fsst, farg = list(data = df, lpmodel = lpm), progress = TRUE)

image

Best, Nadav

conroylau commented 3 years ago

Thanks, Nadav! You're correct and this has been fixed.