conroylau / lpinfer

lpinfer: An R Package for Inference in Linear Programs
GNU General Public License v3.0
3 stars 5 forks source link

Change `lnorm` to `norm` and follow conventions from `norm` base function #18

Closed a-torgovitsky closed 4 years ago

a-torgovitsky commented 4 years ago

Also, be permissive on what the user is allowed to pass to specify the different norms. For example, with the 1-norm, a reasonable user might pass 1 (a number) "1" (a string) "one" "O" "o"

conroylau commented 4 years ago

Done! Changed lnorm to norm.

In addition, I have expanded the list of norms that users can pass to the norm.

For the 1-norm, users may pass

For the 1-norm, users may pass

I will convert the string to lower case so whether they capitalize all or part of the string shouldn't matter.

a-torgovitsky commented 4 years ago

Please close when complete