search

conroylau / lpinfer

lpinfer: An R Package for Inference in Linear Programs
GNU General Public License v3.0
3 stars 5 forks source link

This is a bit hard to follow/debug #31

Closed a-torgovitsky closed 4 years ago

a-torgovitsky commented 4 years ago

https://github.com/conroylau/lpinfer/blob/a8022269592bc40317b0d8af642c99886f3214e6/R/checks.R#L487

I think it would be better to give short descriptive string names for each case.

conroylau commented 4 years ago

Done! Updated the functions to replace the uninformative category numbers with a short descriptive string: https://github.com/conroylau/lpinfer/blob/e3b690938d319598b79e66068e1f4d605671b9b0/R/checks.R#L480 I might revisit this part again later if needed. Thanks!