Incorrect error message for bad solver

conroylau / lpinfer

lpinfer: An R Package for Inference in Linear Programs

GNU General Public License v3.0

3 stars 5 forks source link

Incorrect error message for bad solver #46

Closed a-torgovitsky closed 4 years ago

a-torgovitsky commented 4 years ago

r <- estbounds(data, lpm, solver = "notasolver", norm = 1, kappa = 0)

returns

Error: This function with L2-norm in the estimation procedure is only incompatible with 'gurobi'. Please install 'gurobi' (version 8.1-1 or later) to obtain the bounds of the problem subject to shape restriction.

A few issues

I selected the one norm, so why the reference to two norm?
incompatible should be compatible
Delete after "to obtain bounds..."

conroylau commented 4 years ago

Done! I have fixed the error message for the 2-norm. In addition, I have fixed the issue for referencing the wrong norm. So the above code should give the following error message:

Error: This function is incompatible with 'notasolver' when L1-norm is chosen in the estimation procedure. Please install one of the following packages: 'gurobi' (version 8.1-1 or later); 'cplexAPI' (version 1.3.3 or later); 'Rcplex' (version 0.3-3 or later); 'limSolve' (version 1.5.6 or later).