search

conroylau / lpinfer

lpinfer: An R Package for Inference in Linear Programs
GNU General Public License v3.0
3 stars 5 forks source link

Why do subsample, dkqs and fsst have an "alpha" input? #49

Closed a-torgovitsky closed 4 years ago

a-torgovitsky commented 4 years ago

What is the purpose of this input?

conroylau commented 4 years ago

The alpha input is included because in an earlier version of the module, it is used together with the invertci function to check whether the decision of the test is to reject or do not reject based on the p-value and the significance level. But I have moved this part of comparing the p-values outside the testing function so alpha is not used now actually.

Do you think I should keep this alpha input and add an additional output message to inform the user whether the decision is reject or do not reject, or simply drop this alpha input? Thanks!

a-torgovitsky commented 4 years ago

If it's not used then definitely get rid of it!

conroylau commented 4 years ago

Done! I have updated the code, examples, test files and the README. Thanks!