search

conroylau / lpinfer

lpinfer: An R Package for Inference in Linear Programs
GNU General Public License v3.0
3 stars 5 forks source link

Code duplication and typos #53

Closed a-torgovitsky closed 4 years ago

a-torgovitsky commented 4 years ago

https://github.com/conroylau/lpinfer/blob/0e21a64c00fb1a23e028ae4464baeaa3a62b2e8c/R/checks.R#L34-L52

Do not repeat yourself (ever, even for something like an output message) https://en.wikipedia.org/wiki/Don%27t_repeat_yourself

You should make sure you aren't also doing similar things elsewhere in the code.

conroylau commented 4 years ago

Done! I have fixed the typo here and also updated the code to prevent duplication in the output messages.