search

conroylau / lpinfer

lpinfer: An R Package for Inference in Linear Programs
GNU General Public License v3.0
3 stars 5 forks source link

New warning popping up during install #70

Closed a-torgovitsky closed 4 years ago

a-torgovitsky commented 4 years ago

I saw this today:

NB: this package now depends on R (>= 3.5.0)
     WARNING: Added dependency on R >= 3.5.0 because serialized objects in  serialize/load version 3 cannot be read in older versions of R.  File(s) containing such objects:  'lpinfer/tests/testthat/test_lpm_fsst.RData'
conroylau commented 4 years ago

Done! I have just fixed this.

There was a warning message because I used one of the earlier debug kits in the unit test for the fsst procedure with the d < p case. In that unit test, the lpinfer/tests/testthat/test_lpm_fsst.RData file contains the bootstrap replications.

I have designed another unit test where the new lpmodel object that contains the matrices and functions satisfy the d < p condition without using the RData file. Since the RData file has been deleted, the warning message also goes away now. Thanks!

a-torgovitsky commented 4 years ago

Ok that sounds fine.

But you should be able to use external data in the tests, right? By following the suggestions here: http://r-pkgs.had.co.nz/data.html

conroylau commented 4 years ago

Yes I am able to use external data in the tests (the one called sampledata that is used in the tests).