search

consbio / gis-metadata-parser

Parser for GIS metadata standards including ArcGIS, FGDC and ISO-19115
BSD 3-Clause "New" or "Revised" License
20 stars 3 forks source link

FrozenOrderedDict is removed from frozendict version 2.0.2 #8

Closed nikmolnar closed 3 years ago

nikmolnar commented 3 years ago

The frozendict dependency is listed in setup.py as frozendict >= 1.2. Since 2.0.2 was recently released, it ends up getting installed whenever gis-metadata-parser is freshly installed. This breaks the library, because gis-metadata-parser tries to import FrozenOrderedDict which no longer exists (or not in the same place).

nikmolnar commented 3 years ago

I found where this class was dropped from frozendict, but am not clear on whether or not it was intentional: https://github.com/Marco-Sulla/python-frozendict/issues/22

dharvey-consbio commented 3 years ago

Looks like there is still active conversation on python-frozendict around this.

nikmolnar commented 3 years ago

Yes, for the moment, I suggest pinning frozendict to version 1.2.

dharvey-consbio commented 3 years ago

The frozendict dependency is now pinned at 1.2 in gis-metadata-parser version 1.2.6.

Marco-Sulla commented 3 years ago

If your package it's for python 3.6+ and you don't use __reversed__ or move_to_end, you can safely use from frozendict import frozendict as FrozenOrderedDict, since frozendict is based on dict and dict is ordered by default since Python 3.6

nikmolnar commented 3 years ago

Thanks for the tip, @Marco-Sulla!