consbio / mbtileserver

Basic Go server for mbtiles
ISC License
657 stars 104 forks source link

Add option that allows to specify what IP to listen on #138

Closed Martin8412 closed 2 years ago

Martin8412 commented 2 years ago

This PR adds an option to specify which IP the server should listen on.

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 6.709% when pulling 1842cd37c79dbf5c19755bc99d8d4c5b7ed5f173 on Martin8412:main into a64f45b68896954b8edddbde0d2fd716df43c1ef on consbio:main.

Martin8412 commented 2 years ago

I've updated according to your review

brendan-ward commented 2 years ago

@Martin8412 looks like maybe your force-push reverted an earlier commit? The PR is only showing your original changes, not your latest...

Martin8412 commented 2 years ago

Sorry for the trouble. I rebased the commit to compact it into one, and by doing that apparently removed my own changes ... Should be better now I think

brendan-ward commented 2 years ago

thanks @Martin8412 🎉