search

consbio / mbtileserver

Basic Go server for mbtiles
ISC License
658 stars 104 forks source link

mbtileserver and nginx unit #97

Closed catalinconstant closed 3 years ago

catalinconstant commented 4 years ago

It is possible to have an mbtileserver version o that will work with Nginx UNIT ? https://unit.nginx.org/howto/samples/#sample-go Thank you

brendan-ward commented 4 years ago

We'd have to switch to using UNIT as the web framework instead of echo. I don't see the advantage after reading through the UNIT docs; is there something obvious I'm missing?

catalinconstant commented 4 years ago

Currently I am using tileserver-gl which use express framework, it was very easy to make it work with nginx UNIT just few lines of code const { createServer, IncomingMessage, ServerResponse, } = require('unit-http') require('http').ServerResponse = ServerResponse require('http').IncomingMessage = IncomingMessage const express = require('express') const app = express() and few more tweaks. I was thinking that this is possible with echo framework in GO without changing the application just the http handling through unit-http. In my oppinion UNIT clear has some advantage as an application server orchestarting different microservices from a single point. Since I am quite new to GO I did not know the implications for mbtileserver. Anyway, I started testing mbtileserver and I am quite impresed by its performance.

brendan-ward commented 3 years ago

Closing due to lack of activity. I don't have the bandwidth nor interest at this time to implement UNIT support.