conseilgouz / AutoReadMore-J4

Auto Read More for Joomla 4.x/5.x
GNU General Public License v3.0
10 stars 5 forks source link

Messing with layout #11

Closed Pinkeltje closed 3 months ago

Pinkeltje commented 3 months ago

Joomla 5.1 First of all many thanks for developing this plugin. Unfortunately I've encountered some issues:

When using the plugin (I've used Gruz's plugin in J3, so copied settings), sidebar is pushed to the bottom (in Yootheme) and to the top (in Cassiopeia - sidebar right). Furthermore when there is bold text within the limit of the number of words, date is rendered bold as well. For reference J3 site which is ok: []https://bergenlimburgonline.nl/ Sidebar pushed to top in Cassiopeia 2024-05-16 Screenshot 350

Sidebar pushed to bottom in Yootheme Pro 2024-05-16 Screenshot 351

Bold text for date 2024-05-16 Screenshot 352

Dev site is on localhost, so unable to provide a link.

conseilgouz commented 3 months ago

Hi Astrid,

Thank you for your message.

If you disable Autoreadmore plugin, is your site's layout correct ?

Could you send me a screenshot of Autoreadmore parameters ?

Regards,

Pascal

Pinkeltje commented 3 months ago

Hi Pascal,

Thank you for you quick response. Yes, Layout is correct when disabling plugin. 2024-05-16 Screenshot 354

Screenshots from Gruz's plugin settings on J3 site (working) 2024-05-16 Screenshot 359 2024-05-16 Screenshot 360

Actual screenshots from your plugin settings

2024-05-16 Screenshot 357 2024-05-16 Screenshot 358

Furthermore Gruz's plugin took full article image when no intro image present and yours doesn't unfortunately. Tested with Cassiopeia and Yootheme Pro.

J3 version: 2024-05-16 Screenshot 362

Your version: 2024-05-16 Screenshot 361

Thanks for looking into this.

conseilgouz commented 3 months ago

Hi again,

I just put back htmLawed library which cleans up code when truncation is performed.

That's in new version 5.2.2.

Let me know if it solves your issues.

Pascal

conseilgouz commented 3 months ago

Oups, I forgot to copy htmlLawed library in Helper directory. That's done, version 5.2.3 is now available. Pascal

Pinkeltje commented 3 months ago

Thx! Will have a look tomorrow. Will check Dutch translation as well as it appears to be machine translation (Google or Deepl) and therefore sometimes confusing. Had to set my backend language to English to understand ;-)

conseilgouz commented 3 months ago

I did not touch languages files, they are coming from J3 version. Gruz added a lot of language files when I prefer providing english and french ones for my extensions. You are more than welcome to propose your Dutch language file.

Pinkeltje commented 3 months ago

Hi Pascal,

Please find attached new Dutch language files. Patch is working now for page layout (sidebar is where it should be), but still no full article image shown when no intro image is present in Images and links. Plugin neatly pulls image that is inserted manually in article and image class is working also. NL_plg_content_autoreadmore.zip

conseilgouz commented 3 months ago

Hi,

Thank you for NL language files. I'll release them as soon as possible.

About, full article image, I just made a try and it seems OK. I used your parameters.

I'm making some more tries and let you know if I can reproduce this.

Pascal

conseilgouz commented 3 months ago

Hello Astrid, I was not able to reproduce your full image issue. How is created your article ? what code does it contain ? According to the plugin's code, it's looking for the first img tag if no introduction image exists. Are you using a plugin to display your image (like responsive image plugin from Grammatiko) ? In this case, images are not in an img tag but using picture / srcset tags.

Pascal

Pinkeltje commented 3 months ago

Hi Pascal,

Really don't understand it. Screenshots from clean Joomla 5 install with Cassiopeia.

Intro on homepage: 2024-05-19 Screenshot 364

Full article 2024-05-19 Screenshot 365

Astrid

conseilgouz commented 3 months ago

Thank you Astrid for telling me about the notice. I use this plugin with Joomla 4 & joomla 5 sites, but, I don't use Cassiopeia template. I'm doing some more testings and let you know if I can reproduce your issue with a J510 clean install. Pascal

Pinkeltje commented 3 months ago

I normally use Yootheme Pro template. But decided to test with everything default to eliminate any conflicts with extensions or templates.

conseilgouz commented 3 months ago

Hi again, I just installed a clean J510, used the examples data. I created a new article and everything is fine. If you disable Autoreadmore plugin and add a readmore in your article, is your image displayed ? If not, it must be an article or menu parameter error. Pascal autoreadmore_article

autoreadmore_article_debug

Blog display

autoreadmore_feature

When clicking on readmore button, full article display

autoreadmore_site

Pinkeltje commented 3 months ago

I think there is a misunderstanding. You are having your image inside the article. That works for me also. But my problem is with the image inserted through the Images and Links tab, when only having a full article image. Hope the link to the J3 site and the screenshots clarifies my issue. J5 site is on localhost, so unable to provide a link.

I'm updating a Joomla 3 site with Gruz's plugin []https://t.ly/JgbCg

2024-05-19 Screenshot 370

After the update and using your version of the plugin, this isn't working anymore.

2024-05-19 Screenshot 373

2024-05-19 Screenshot 371

conseilgouz commented 3 months ago

Ok, I see.

The problem is that, to work, the plugin should call image_fulltext, but it does not, and never did : I checked in the previous versions and could not find this.

I think it's normal as image_intro is to be displayed in blog/feature modes when image_fulltext will be when the whole article is displayed.

Even if it does not make sens, I think I'll work on this as you set "force image count" parameter to 1, which means "find any image in my article".

I'll let you know as soon it's available.

Pascal

conseilgouz commented 3 months ago

Hi again,

Version 5.2.5 implements "use fulltext image if no other image can be found".

Let me know if this closes the current issue.

Pascal

Pinkeltje commented 3 months ago

Hi Pascal,

The problem is that, to work, the plugin should call image_fulltext, but it does not, and never did : I checked in the previous versions and could not find this.

Was looking for that in old plugin as well, and couldn't find it either. That's why it's so strange that it worked with Gruz's version....

But the good news is that it works like a charm now. Thanks a lot, merci beaucoup, for your hard work.

Astrid

2024-05-19 Screenshot 374

conseilgouz commented 3 months ago

issues solved by version 5.2.4 & 5.2.5